Add Nexus worker service for server-to-worker commands#708
Open
rkannan82 wants to merge 4 commits intokannan/add-worker-instance-key-to-wft-completefrom
Open
Add Nexus worker service for server-to-worker commands#708rkannan82 wants to merge 4 commits intokannan/add-worker-instance-key-to-wft-completefrom
rkannan82 wants to merge 4 commits intokannan/add-worker-instance-key-to-wft-completefrom
Conversation
rkannan82
force-pushed
the
kannan/activity-cancel
branch
3 times, most recently
from
4b2e0d1 to
54edb8e
Compare
cretz
reviewed
Feb 3, 2026
rkannan82
force-pushed
the
kannan/activity-cancel
branch
2 times, most recently
from
afb40a2 to
b920471
Compare
rkannan82
changed the title
rkannan82
force-pushed
the
kannan/activity-cancel
branch
from
b920471 to
84c0bac
Compare
cretz
reviewed
Feb 9, 2026
Contributor
cretz
left a comment
cretz
left a comment
There was a problem hiding this comment.
LGTM, though would want to see end-to-end working including in an SDK if possible before approving
rkannan82
force-pushed
the
kannan/activity-cancel
branch
from
84c0bac to
28ea1dd
Compare
rkannan82
changed the base branch from
master
to
kannan/add-worker-instance-key-to-wft-complete
rkannan82
force-pushed
the
kannan/activity-cancel
branch
from
7d3bfb7 to
e0d0049
Compare
rkannan82
force-pushed
the
kannan/add-worker-instance-key-to-wft-complete
branch
from
61952c9 to
98350a9
Compare
rkannan82
force-pushed
the
kannan/activity-cancel
branch
from
e0d0049 to
6c21af4
Compare
bergundy
approved these changes
Feb 12, 2026
Member
bergundy
left a comment
bergundy
left a comment
There was a problem hiding this comment.
LGTM, don't merge this until you've generated the code and verified that this API works across SDK and server.
There will probably be a separate code generation project that will construct the YAML from protos to prevent the need to define services in separate places but this is a good start IMHO.
cretz
reviewed
Feb 12, 2026
Contributor
cretz
left a comment
cretz
left a comment
There was a problem hiding this comment.
This is our first Nexus service, so lots of things undecided. I added comments, but would like to hear others' opinions.
yuandrew
reviewed
Feb 17, 2026
rkannan82
force-pushed
the
kannan/activity-cancel
branch
from
6c21af4 to
37ffb33
Compare
rkannan82
force-pushed
the
kannan/activity-cancel
branch
from
37ffb33 to
6c21af4
Compare
rkannan82
changed the title
Sushisource
reviewed
Feb 27, 2026
temporal/api/nexusservices/workerservice/v1/request_response.proto
Outdated
Show resolved
Hide resolved
bergundy
reviewed
Feb 27, 2026
temporal/api/nexusservices/workerservice/v1/request_response.proto
Outdated
Show resolved
Hide resolved
temporal/api/nexusservices/workerservice/v1/request_response.proto
Outdated
Show resolved
Hide resolved
temporal/api/nexusservices/workerservice/v1/request_response.proto
Outdated
Show resolved
Hide resolved
temporal/api/nexusservices/workerservice/v1/request_response.proto
Outdated
Show resolved
Hide resolved
temporal/api/nexusservices/workerservice/v1/request_response.proto
Outdated
Show resolved
Hide resolved
Made-with: Cursor
rkannan82
force-pushed
the
kannan/activity-cancel
branch
from
32523fb to
cfff488
Compare
…vity-cancel Made-with: Cursor
- Rename WorkerCommandsRequest/Response to ExecuteCommandsRequest/Response to match the operation name (bergundy feedback) - Change operation name from executeCommands to ExecuteCommands (PascalCase) - Add doc: results list must be 1:1 with commands list (Sushisource feedback) Made-with: Cursor
Move WorkerCommand, CancelActivityCommand, WorkerCommandResult, and CancelActivityResult to temporal.api.worker.v1 as top-level messages. request_response.proto now only contains ExecuteCommandsRequest and ExecuteCommandsResponse, following the repo convention. (bergundy feedback) Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Defines a Nexus service for server-to-worker communication, starting with activity cancellation support.
Design Decision
We chose a generic command API (
ExecuteCommandsRequestwithoneofcommand types) instead of a cancel-specific API. This allows a future optimization to batch multiple commands (cancel, pause, etc) in a single request and deliver to a worker in one RPC.Files
temporal/api/nexusservices/workerservice/v1/request_response.proto- request response definitionstemporal/api/nexusservices/workerservice/v1/service.yaml- Nexus service definitionRelated